https://bugzilla.redhat.com/show_bug.cgi?id=1403600
--- Comment #5 from Simone Caronni <negativ...@gmail.com> --- There is libtiff missing in the build dependencies, build fails with: Make Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148 (message): Could NOT find TIFF (missing: TIFF_LIBRARY TIFF_INCLUDE_DIR) Call Stack (most recent call first): /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake/Modules/FindTIFF.cmake:82 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:146 (find_package) -- Configuring incomplete, errors occurred! If you use mock also to build locally, you can spot all missing dependencies easily. The rest of the SPEC file looks ok, but packaging guidelines for the snapshots are slightly different: https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Commit_Revision I would use something like this (date+git) as proposed in the page since you have 2 different snapshots: %global commit0 0ab187e78ef1f16f3fbb22422dc614e8abd6aaef %global commit1 ac472bc511ffa5b2706a02102fd85fe06bb24265 %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) %global shortcommit1 %(c=%{commit1}; echo ${c:0:7}) %global date 20170131 Version: 3.2.0 Release: 0.1.%{date}git%{?dist} And then these lines in the Source tags: Source0: https://github.com/%{name}/Core/archive/%{commit0}.tar.gz#/Core-%{shortcommit0}.tar.gz Source1: https://github.com/%{name}/Blender-Exporter/archive/%{commit1}.tar.gz#/Blender-Exporter-%{shortcommit1}.tar.gz Once the sources are properly declared, you can just run "spectool -g YafaRay.spec" to download the tarballs, the "#" after the source url means that the package should be named as such. In the end, by running spectool -g you should get these 2 files in the folder: Core-0ab187e.tar.gz Blender-Exporter-ac472bc.tar.gz And then run rpmdev-bumspec -c "<comment>" YafaRay.spec to put the correct version/releases in the %changelog as well. Please also remove the wget comment in the SPEC file, it's confusing, only spectool should be used if the source url is valid. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
