https://bugzilla.redhat.com/show_bug.cgi?id=1421245
Kees de Jong <keesdejong+b...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |keesdejong+b...@gmail.com
--- Comment #2 from Kees de Jong <keesdejong+b...@gmail.com> ---
I'm trying to gain some reputation to get my own package sponsored, so I will
give it a go ahead to review yours. If you want you could give my much simpler
package a review in return [1], if you don't see any improvements, then please
leave a comment that you approve the package.
According to the Fedora package documentation, the BuildRoot should be left
untouched [2].
Another remark, the use of %defattr is no longer necessary unless the
permissions need to be altered [3].
Your changelog is empty, you could bump it with `rpmdev-bumpspec -c 'this is my
first package'`.
The release tag should be like '1%{?dist}' [2]. The group tag is deprecated
[2].
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1411984
[2]
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview
[3] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
