https://bugzilla.redhat.com/show_bug.cgi?id=1409355
--- Comment #3 from Mamoru TASAKA <mtas...@fedoraproject.org> --- Hello, again sorry for long delay... (In reply to František Dvořák from comment #1) > It looks like, there is a problem with stability. I've tested: > /usr/share/gems/gems/tk-0.1.1/sample/demos-en/widget dialog2 > And there are two problems: > > 1) Occasionally there is a cryptic error message: > > invalid command name ".w00010.msg" > > This message occurs also on F25 (with both: ruby-tcltk package, or > recompiled rubygem-tk), so this is already existing problem (not a > show-stopper for upgrade from ruby-tcltk). Currently I don't see this issue (yet?) > 2) When closing the demo window, ruby crashes. > > Ruby won't crash in F25, so this is a new problem with F26. > > I'm not sure, what to do with the second problem. Continue with packaging > and report upstream? It is possible it is only bug in the demo code? (there > are used threads, ...). Will try on F-26, however currently I think this is ruby issue (perhaps), may be bug 1417590 : GC issue with gcc7, hopefully fixed in ruby-2.4.0-76.fc26 > Now the packaging itself, the easier part: :-) > > 3) the modification of gem.build_complete > > It is interesting way, how to solve the rpmlint error. But the real fix > probably belongs to the rpmlint. Maybe it could be better to know about it > in the bodhi tests (and keep the error)? > > Another way (without the real fix though) could be to use ".rpmlint" config > file in the fedora git package sources. Well, as you know this is just to suppress rpmlint error (if reviewer does not like rpmlint error). If you are okay, I can just make gem.build.complete unmodified (i.e. just empty). > 4) gcc dependency is not needed Unfortunately now this is MUST :( https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires > 5) it could be safer to replace '/usr/local' and '/usr/bin/env ruby' only in > 'sample' subdirectory (just a hint to consider, checking everything is > probably fine and desired?) Because rpmlint warns these :( (Well, anyway we don't support /usr/local so I think this is okay) > 6) missing the "Provides: ruby-tcltk" > > There is comment about it, so it is probably OK a there is reason for it > (not full functionality provided by 'tk' gem?). I've noticed there is still > a TCL part available - at least the variable Tk::TCL_VERSION. The reason for this is that while I think (believe) ruby-tcltk functionality is fully provided by rubygem-tk, I am not sure at a moment. Let me know it if you think it is better to modify. Again sorry for long delay... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
