https://bugzilla.redhat.com/show_bug.cgi?id=1421856
--- Comment #1 from Tomas Tomecek <ttome...@redhat.com> --- Same as flannel, please pin base image to latest stable tag: > FROM fedora https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT https://github.com/projectatomic/atomic-system-containers/blob/master/etcd/Dockerfile#L13 > RUN dnf -y install etcd hostname && \ This also holds for flannel: please install packages without documentation as described in "Container best practices": http://docs.projectatomic.io/container-best-practices/#_clear_packaging_caches_and_temporary_package_downloads It would be also helpful to indicate which ports are meant to be exposed (you write that the container is meant to run as system container, but one can still run it within docker, right?) > # git clone https://github.com/aveshagarwal/etcd-container `git clone` in readme seems to be out of date. Same for documentation, it would be really helpful for users to have something. But I guess since there are no formal guidelines for this, let's postpone (same for flannel), there is readme in the repo, should be enough for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
