Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635511

--- Comment #4 from Ralf Corsepius <rc040...@freenet.de> 2010-09-20 02:19:56 
EDT ---
Partial review:

* Remove
BuildRequires: ccache

assimp does not build-require ccache.


* Remove from *-devel
Requires: pkgconfig cmake

assimp doesn't ship pkgconfig files nor cmake files.


* Consider building the doxygen docs from sources.

Apart of these, the package seems basically fine to me.

One outstanding issue, I haven't checked for yet: 
The *devel package's deps likely are incomplete.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to