https://bugzilla.redhat.com/show_bug.cgi?id=1427634
--- Comment #5 from Jan Chaloupka <jchal...@redhat.com> --- > i) gofed generates quite a long list of BR's and Requires, but all of those > are > bundled in the upstream tarball (and not all of them are in fedora yet). > Should > I strip the "vendored" / bundled libraries before %build? (I know fedora > doesn't like bundled stuff ...) If so, I'll probably have to open review > requests for the packages missing from fedora, and BR: those packages. Whenever you can de-bundle please do so. You should use a dependency in vendor directory only when there is no other option. E.g. - dependency in the distribution is not backward compatible and there is no reasonable way to patch your project - dependency is changing very rapidly and you have no assurance of API stability (e.g. kubernetes, docker) > ii) I think I should include the following Provides to match the usual naming > scheme for golang packages. Is that a good idea? > >- syncthing provides golang-github-syncthing-syncthing, >- syncthing-devel provides > - golang-github-syncthing-syncthing-devel and Name of the devel subpackage is not important. Every go package should/must [Build]Require virtual provides (golang(...)) So no need to introduce additional provide > - golang(github.com/syncthing/syncthing) List of provided packages in devel package is generated by gofed by default. Optionally, you can run ``gofed inspect -p --spec`` inside the tarball to get a list of all provided packages in spec format. >- syncthing-unit-test-devel provides > - golang-github-syncthing-syncthing-unit-test-devel The unit-test-devel package is never meant to be [Build]Required so no need for it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
