https://bugzilla.redhat.com/show_bug.cgi?id=1430132
--- Comment #2 from Fabio Valentini <decatho...@gmail.com> --- It would have been nice if you provided a successful koji scratch build for rawhide - it shows that the package builds and that tests succeed on all architectures. [0] I see two issues with the current .spec and package: 1. Why are you packaging a specific commit that is over half a year old, and not the latest git master? 2. Is it reasonable to include the sources+provides for > golang(github.com/google/go-github/tests/integration) in the package, e.g. are those sources imported by any packages using this library, or are they only internal tests? If the tests are just used internally, exclude them from the -devel and -unit-test-devel package (for example by removing the sources before running the scripts generated by gofed). I had to do that for one of my packages, see [1]. [0]: https://koji.fedoraproject.org/koji/taskinfo?taskID=18265357 [1]: https://src.fedoraproject.org/cgit/rpms/golang-github-d4l3k-messagediff.git/tree/golang-github-d4l3k-messagediff.spec#n93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
