https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Ralf Corsepius <rc040...@freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040...@freenet.de



--- Comment #2 from Ralf Corsepius <rc040...@freenet.de> ---
Not a formal review just some remarks:

- Building package is not verbose. 
Please append --disable-silent-rules to %configure.

- The package contains a tarball named "0.9.7.tar.gz"
I would propose to change Source0 into:
Source0:       
https://github.com/%{gh_owner}/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz

This lets downloading from github create a tarball named "lldpd-0.9.7.tar.gz"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to