Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=623604 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) <pa...@hubbitus.info> 2010-09-24 08:28:14 EDT --- Damian and Martin, firstly thanks for the (pre)review. (In reply to comment #1) > - MUST: The License field in the package spec file must match the actual > license. > > $ grep -B 1 later xneur-0.9.9/COPYING > specifies a version number of this License which applies to it and "any > later version", you have the option of following the terms and conditions > either of that version or of any later version published by the Free > -- > the Free Software Foundation; either version 2 of the License, or > (at your option) any later version. > > NOT OK. The spec says it's GPLv2, but the licens is "or later version" > like[1], > so the GPLv2+ should be used instead. You are quote incorrect file - this is onlu standard text on GPLv2 license and phrase "or later version" there used in context of example of use it. By the way, you are accidentally right, and source say also it should be GPLv2+. Fixed. > - MUST: The package MUST successfully compile and build into binary rpms on at > least one primary architecture. > > NOT OK. > It doesn't build for i686 in mock for F-14 and F-15(rawhide) [3]. > Please look for: > /usr/include/libnotify/notification.h:28:21: fatal error: gtk/gtk.h: No such > file or directory > compilation terminated. Eeeh. You are right, very thanks. It built fine on Fedora 13 thought. Now I ask it in ML (http://www.mail-archive.com/de...@lists.fedoraproject.org/msg15816.html) and apply workaround. > NOT OK. > It looks that the package doesn't own all necessary directories > (/usr/lib/xneur)[5]. Good point, fixed. > Just please consider to replace %{_libdir}/xneur/*.so.* > with the %{_libdir}/%{name}/*.so.* Replaced. (In reply to comment #2) > Hi Pavel and Damian > > (In reply to comment #1) > > NOT OK. > > The summary attempts to compare this program to a different one: > > "It's program like Punto Switcher, ..." > > which should be avoided[2]. BTW, for people who don't know what the > > Punto Switches program is designed for, such a comparison is rather useless. > > I agree here. I suggest to use a slightly shortened paragraph from Wikipedia, > for example: > > X Neural Switcher is a program for automatic (intelligent) keyboard layout > changing in the X Window System. It is mainly used to change between Russian > and English, but also supports Ukrainian, Belorussian, French, Romanian, > Kazakh > and German. It sounds good to me. I take it with only full lists of supported languages. > > - MUST: Packages must NOT OK bundle copies of system libraries. > > > > NOT OK. > > It looks that it the xneur library needs to be packaged separately[4]. > > It's OK to put libraries that are an original part of the program into the > same > package as the program (here: xneur and libxneur). Nonetheless, it might be > useful to put the library in a subpackage to avoid conflicts in multilib > environments (where the 32bit and 64bit version of the library are installed). > But this is up to the packager. I think it is not intended use of this library anywhere outside xneur. So, it is not system library then. I do not willing packaging it separately until some one ask it for its work. > > NOT OK. > > It looks that the package doesn't own all necessary directories > > (/usr/lib/xneur)[5]. > > Right. Add "%dir %{_libdir}/xneur" to the base package to make the package own > this directory. Also, replace "%{includedir}/xneur/*" with > "%{includedir}/xneur/". It adds the directory plus its contents. Fixed, thanks. But I only prefer use %{name} there instead of directly mention "xneur". > Here are some more notes: > - BR: autoconf, automake, and libtool are not required and should be removed Removed. > - libxnconfig and xneur contain rpaths (see rpmlint output below). > The rpath must be removed. > http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath It is not problem for internal libraries - http://fedoraproject.org/wiki/Packaging/Guidelines#Rpath_for_Internal_Libraries > - I recommend to be more specific in %files to avoid packaging unwanted files: > %{_bindir}/xneur I use it (again with macros variant %{name}). > %{_mandir}/man1/xneur.1* > %{_mandir}/man5/xneurrc.5* I do not see any worth on it - we always want include all available mans. > $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm > xneur.src: I: enchant-dictionary-not-found ru If I understand it correctly - you just do not have installed ru dictionary for hunspell and rpmlint can't spell it language. Errors about zero-length files may be safely ignored. I want leave it in package as upstream make it - it just as placeholders. http://hubbitus.net.ru/rpm/Fedora13/xneur/xneur-0.9.9-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
