Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636945 --- Comment #3 from Petr Pisar <ppi...@redhat.com> 2010-09-24 09:31:32 EDT --- > FIX: Summary text does not end with full stop. TODO: Summary should be a sentence. Append a period character. > FIX: BuildRequires perl(Exporter) (check-time) missing. This is needed because > Exporter package could be dual-life in the future > (http://search.cpan.org/search?query=Exporter&mode=all). Ok. > TODO: Remove unneeded BuildRoot tag as this is obviously post-F12 spec (no > %clean section). Ok. > TODO: Report bad interpreter path in puudecode to upstream. Ok (https://rt.cpan.org/Public/Bug/Display.html?id=61609). > FIX: Remove puudecode puuencode from %doc (effectively same as in %{_bindir}) Ok. > FIX: Package %{perl_privlib}/* instead of %{perl_vendorlib}/* > (INSTALLDIRS=perl) Ok. > FIX: Does not builds on F15 > (http://koji.fedoraproject.org/koji/taskinfo?taskID=2486640). Ok (http://koji.fedoraproject.org/koji/taskinfo?taskID=2486852). See build.log: + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/ext-uu.t .... skipped: (no reason given) TODO: Investigate why the test was skipped. It works for me on local. I guess it executes `uudecode' utility from sharutils RPM package (t/ext-uu.t:10). Try to BuildRequire sharutils. > FIX: Add BuildRequires necessary for %check phase: perl(File::Spec), > perl(Test::More), perl(Test::Pod) >= 1.00, perl(Test::Pod::Coverage). Ok Please consider fixing all `TODO:' prefixed comments. Result: APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
