https://bugzilla.redhat.com/show_bug.cgi?id=1440406
--- Comment #4 from Björn "besser82" Esser <besse...@fedoraproject.org> --- (In reply to Jens Lody from comment #3) > Looks good so far. > There are two or three questions: > > Shouldn't the versioned Requires only have a single equal-sign ? Well, it works with a single or a double equal-sign (tested from el5 to recent Fedora). I simply prefer the doubled one, because - from perspective of a hacker - it looks more obvious like a comparison than an assignment. > What about the dbus-files ? > The service-file should be under /usr/, but no other package installs the > *.conf-file there, they all keep (or install) it under /etc. I did not find > anything in the guidelines about that. There is nothing noted in the guidelines, but there is a common rule of thumb saying: User editable / customizable config goes in /etc, system-presets go to /usr/share. > Shouldn't the service be enabled as default ? > And therefore get a preset-file ? > I think it might be expected by the normal user to work out of the box with > default settings. > It should be covered by > https://fedoraproject.org/wiki/Packaging: > DefaultServices#Locally_running_services . Just requested a systemd-preset for it: https://bugzilla.redhat.com/show_bug.cgi?id=1440479 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
