Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636250 Orion Poplawski <or...@cora.nwra.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #7 from Orion Poplawski <or...@cora.nwra.com> 2010-09-24 11:49:55 EDT --- Two minor things, but otherwise approved: - Often symbolic links to versioned jars are installed, e.g.: %install ... install -D -m 644 build/jar/%{name}.jar %{buildroot}/%{_javadir}/%{name}-%{version}.jar ln -s %{name}-%{version}.jar %{buildroot}/%{_javadir}/%{name}.jar %files ... %{_javadir}/%{name}.jar %{_javadir}/%{name}-%{version}.jar - Seems like your tab spacing is not 8 chars, I would format for that since it is standard. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
