https://bugzilla.redhat.com/show_bug.cgi?id=1411962
Fabio Valentini <decatho...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #11 from Fabio Valentini <decatho...@gmail.com> ---
It's nice that is was possible to resolve the bug upstream!
The tests pass now:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19065240
My final review uncovered one last minor issue:
<snip>
Note: No known owner of
/usr/share/gocode/src/github.com/milochristiansen/lua/vendor
<snip>
You should add this as a %dir to the -devel subpackage before importing the
package (no additional changelog entry is necessary from my point of view).
For example, add something like the following at line 104 (similar to line
103):
echo "%%dir %%{gopath}/src/%%{import_path}/vendor" >> devel.file-list
But since it's only a very minor issue, the package is approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
