https://bugzilla.redhat.com/show_bug.cgi?id=1450633
--- Comment #5 from Mukundan Ragavan <nonamed...@gmail.com> --- Created attachment 1279518 --> https://bugzilla.redhat.com/attachment.cgi?id=1279518&action=edit specfile patch Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ---> This is alright. This is not in the ld path [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "*No copyright* CC0 (v1.0)", "GPL (v2)", "Unknown or generated", "BSD (3 clause) GPL", "MIT/X11 (BSD like)", "BSL (v1.0)", "*No copyright* BSD (3 clause)", "*No copyright* BSL", "BSD (3 clause)", "GPL (v2.1) LGPL (v2.1)", "GPL (v3)", "LGPL (v2.1 or v3)", "*No copyright* GPL (v2)". 316 files have unknown license. Detailed output of licensecheck in /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/licensecheck.txt ---> Well, I don't think this should be GPLv2 only. If you look at the COPYING file in the tarball, there is a big mix of several licenses. Icon files have the following licenses - LGPL-2, LGPL-2.1, LGPL-3+, CCO, public domain. In addition, there is some code that has licenses Boost-1.0 and BSD 3-clause. All of this has to go into the license field. Please cross-check using the COPYING file (also attached). [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/keepassxc ---> This is easily fixed. In %files, %{_libdir}/%{name} instead of %{_libdir}/keepassxc/*.so [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mimelnk/application, /usr/share/mimelnk, /usr/share/mime/packages, /usr/share/mime, /usr/lib64/keepassxc, /usr/share/icons/hicolor ---> Some of these bogus warnings. For example, /usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info /usr/share/icons/hicolor - hicolor-icon-theme others are provided by several other packages (kde-filesystem, for example) /usr/lib64/keepassxc fix is above. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/scalable/mimetypes(hicolor-icon- theme), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/24x24/apps(hicolor- icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/24x24 (hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/64x64(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/mimetypes (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/16x16 (hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/128x128(hicolor- icon-theme, keepassx), /usr/share/icons/hicolor/22x22/mimetypes (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/32x32 (hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/256x256(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/apps(hicolor- icon-theme, keepassx), /usr/share/icons/hicolor/22x22(hicolor-icon- theme, fedora-logos, keepassx), /usr/share/icons/hicolor/48x48 (hicolor-icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/32x32/mimetypes(hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora-logos, keepassx) ---> Most of these directories are owned by hicolor-icon-theme or fedora-logos even if keepassx is not present. This issue is due to %{_datadir}/icons/hicolor/* If you specify the icon files in a granular fashion, this will mostly go away. %{_datadir}/icons/hicolor/*/*/*keepassxc* I think this will fix it. May be. So, owning the files created is probably a good solution. [!]: %build honors applicable compiler flags or justifies otherwise. ---> Please use %cmake macro. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in keepassxc [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in keepassxc [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. ---> This is fine. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: update-mime-database is invoked in %post and %postun if package stores mime configuration in /usr/share/mime/packages. Note: mimeinfo files in: keepassxc See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo ---> running update-mime-database is only applicable for F23 or older. This is fine. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in keepassxc-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint ---> fedora-review crashed for some reason. rpmlint messages in the next comment. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1710080 bytes in /usr/share [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.1 starting (python version = 3.6.1)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.1 INFO: Mock Version: 1.4.1 Finish: chroot init INFO: installing package(s): /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/results/keepassxc-debuginfo-2.1.4-1.fc27.x86_64.rpm /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/results/keepassxc-2.1.4-1.fc27.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M daf9e15b8c85470292b7155ebbce3a1e -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=en_US.utf8 --setenv=LC_MESSAGES=C /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 27 --disableplugin=local --setopt=deltarpm=false install /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/results/keepassxc-debuginfo-2.1.4-1.fc27.x86_64.rpm /home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/results/keepassxc-2.1.4-1.fc27.x86_64.rpm Rpmlint ------- Checking: keepassxc-2.1.4-1.fc27.x86_64.rpm keepassxc-debuginfo-2.1.4-1.fc27.x86_64.rpm keepassxc-2.1.4-1.fc27.src.rpm keepassxc.x86_64: W: spelling-error %description -l en_US urls -> curls, purls, hurls keepassxc.x86_64: W: spelling-error %description -l en_US attachemts -> attachments, attache, schemata ---> please fix this. keepassxc.x86_64: W: spelling-error %description -l en_US customizable -> customization keepassxc.x86_64: W: hidden-file-or-dir /usr/lib/.build-id keepassxc.x86_64: W: hidden-file-or-dir /usr/lib/.build-id ---> Please remove this after install keepassxc.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/keepassxc-dark.svgz keepassxc.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/keepassxc-locked.svgz keepassxc.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/keepassxc.svgz keepassxc.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/mimetypes/application-x-keepassxc.svgz keepassxc.x86_64: W: no-manual-page-for-binary keepassxc keepassxc-debuginfo.x86_64: E: debuginfo-without-sources keepassxc.src: W: spelling-error %description -l en_US urls -> curls, purls, hurls keepassxc.src: W: spelling-error %description -l en_US attachemts -> attachments, attache, schemata ---> please fix this. keepassxc.src: W: spelling-error %description -l en_US customizable -> customization keepassxc.src: W: strange-permission keepassxc-2.1.4-src.tar.xz 400 keepassxc.src:40: W: setup-not-quiet 3 packages and 0 specfiles checked; 1 errors, 15 warnings. Requires -------- keepassxc (rpmlib, GLIBC filtered): /bin/sh libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.9)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libXi.so.6()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) keepassxc-debuginfo (rpmlib, GLIBC filtered): Provides -------- keepassxc: application() application(keepassxc.desktop) keepassxc keepassxc(x86-64) libkeepassx-autotype-xcb.so()(64bit) mimehandler(application/x-keepass2) mimehandler(application/x-keepassxc) keepassxc-debuginfo: keepassxc-debuginfo keepassxc-debuginfo(x86-64) Unversioned so-files -------------------- keepassxc: /usr/lib64/keepassxc/libkeepassx-autotype-xcb.so Source checksums ---------------- https://github.com/keepassxreboot/keepassxc/releases/download/2.1.4/keepassxc-2.1.4-src.tar.xz : CHECKSUM(SHA256) this package : 22c564fab78bd960b9af5a779c7bd59f0cc04a9988b00c6b82329059e59b0035 CHECKSUM(SHA256) upstream package : 22c564fab78bd960b9af5a779c7bd59f0cc04a9988b00c6b82329059e59b0035 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1450633 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
