https://bugzilla.redhat.com/show_bug.cgi?id=1433749



--- Comment #9 from Neal Gompa <ngomp...@gmail.com> ---
> URL:           https://github.com/%{githubowner}/%{name}/
> Source0:       %{url}archive/%{gittag0}.tar.gz#/%{name}-%{gittag0}.tar.gz

Please adjust the URL structure to be properly segmented. For example:

URL:           https://github.com/%{githubowner}/%{name}
Source0:       %{url}/archive/%{gittag0}/%{name}-%{gittag0}.tar.gz

> make build PREFIX=/usr %{?_smp_mflags}

Please use %{_prefix} for PREFIX= value. Also, as an alternative, you can
simplify this with "%make_build PREFIX=%{_prefix}"

> make install PREFIX=%{buildroot}/usr %{?_smp_mflags}

Use %{buildroot}%{_prefix} here. Also, consider supporting DESTDIR so that the
standard %make_install macro works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to