https://bugzilla.redhat.com/show_bug.cgi?id=1439894
Zdenek Dohnal <zdoh...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(e...@redhat.com)
--- Comment #14 from Zdenek Dohnal <zdoh...@redhat.com> ---
(In reply to Eugene Syromiatnikov from comment #12)
> (In reply to Zdenek Dohnal from comment #10)
> > - if it is not python module (it is not meant to import ddiskit scripts in
> > other
> > programs), no directory /usr/lib/python2.7/site-packages/ddiskit and files
> > in it shouldn't be there
>
> Well, it is written in a way which does not prohibit import, and it actually
> may be useful in some use cases, but so far there's no clear separation of
> the package-able commands as an autonomous package from the CLI part (i.e.
> they are both implemented in ddiskit.py).
Ok, I think we need to understand what ddiskit tool should be. There are two
ways (other is more complicated...) and each has consequences:
1) ddiskit will be a tool written in python, not python module - other python
scripts won't be able to import it - name will be ddiskit and there will not be
any files in %{python_sitelib}
or
2) ddiskit will be a python module - other scripts will be able to import it
(there will be files in %{python_sitelib}), here are difficulties come:
a) ddiskit will support both Pythons - then name of source rpm must be
python-ddiskit and generates binary rpms python2-ddiskit and python3-ddiskit
b) ddiskit will support Python-2.7 only (IMHO I will not recommend it,
because in near future python3 will become "main" python and python-2.7) -
source rpm and binary rpm will be python2-ddiskit
c) ddiskit will support only Python3 - source rpm and binary rpm will be
python3-ddiskit
Which is applicable for ddiskit? I thought it is tool only and its scripts will
not be importable - this is what I got from talk with Petr Oros.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
