https://bugzilla.redhat.com/show_bug.cgi?id=1467651
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
> %global debug_package %{nil}
Are you sure that's needed? If yes, it deserves a comment in the spec file.
> make
Is parallel build not supported? If it is, use %make_build, otherwise, add a
comment.
> %{__install}
You can just say 'install' — that's both less typing *and* clearer.
> %defattr(-,root,root)
Not needed.
Checking: cvechecker-3.7-1.fc27.x86_64.rpm
cvechecker-3.7-1.fc27.src.rpm
cvechecker.x86_64: W: unstripped-binary-or-object /usr/bin/cvechecker
Hm. That's the first time I encounter this. Maybe this will go away if you
create a debug package?
cvechecker.x86_64: W: only-non-binary-in-usr-lib
cvechecker.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
cvechecker.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
OK.
cvechecker.src:13: W: macro-in-comment %{url}
cvechecker.src:13: W: macro-in-comment %{_commit}
cvechecker.src:13: W: macro-in-comment %{_commit}
Please use %%.
cvechecker.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line
14)
Please fix.
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Looks all good.
(It seems that cvechecker likes to run as root. It'd be much better to create a
dedicated user for it, since downloading stuff as root from the web is also a
concern, but that's an upstream issue.)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
