https://bugzilla.redhat.com/show_bug.cgi?id=1467762
--- Comment #2 from Igor Gnatenko <ignate...@redhat.com> ---
* License is GPLv3+, not GPLv3
* You install systemd files, but you miss %{?systemd_requires}
* Systemd service is instlaled, but scriptlets are missing
* Missing BuildRequires: perl-generators (because you don't have automatic
dependencies for perl modules)
* %{?perl_default_filter} sounds unneeded
* %if 0%{?rhel} <= 7 is wrong, because on fedora %rhel == 0 (which matches
%if), it should be %if 0%{?rhel} && 0%{?rhel} <= 7
* install calls miss -p to preserve timestamps
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
