https://bugzilla.redhat.com/show_bug.cgi?id=1461368
Ben Rosser <rosser....@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #1 from Ben Rosser <rosser....@gmail.com> ---
A couple of initial comments. I'm not terribly familiar with MinGW, so
apologies if any of these are stupid things to ask.
- What's the purpose of these four lines?
rm -rf %{buildroot}%{mingw32_datadir}/doc/*
rm -rf %{buildroot}%{mingw64_datadir}/doc/*
rm -rf %{buildroot}%{mingw32_datadir}/man/*
rm -rf %{buildroot}%{mingw64_datadir}/man/*
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Filesystem_location_macros
implies that this is indeed where man pages should be installed. Is there a
reason they're being removed by %install? If so that should be stated in a
comment somewhere.
- Closely related to the above comment, but all four built packages have no
documentation. Is there something that can be installed somwehere? Is there a
reason that whatever gets installed in %install isn't kept?
- The -static subpackages should have a %license tag as well, as they can be
installed separately from the main packages.
- pcre2grep and pcre2test are listed twice in both the mingw32 and mingw64 file
lists; is there a reason for this?
%{mingw32_bindir}/pcre2grep.exe
%{mingw32_bindir}/pcre2test.exe
%{mingw32_bindir}/pcre2grep.exe
%{mingw32_bindir}/pcre2test.exe
Otherwise, I think the package is okay.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
