https://bugzilla.redhat.com/show_bug.cgi?id=1475961
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
A small cleanup:
https://github.com/01org/cmrt/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
→
https://github.com/01org/cmrt/archive/%{version}/%{name}-%{version}.tar.gz
%description should end in a dot (those are full sentences). It would be great
if you could add a sentence or two what this package does (something like "It
allows ... to ... with ...".)
Please don't put multiple Requires/BuildRequires/etc on the same line,
especially when there are versions. It's more legible and looks much better in
diffs when it's one-per-line.
Hmm, "%autosetup -p1 n %{name}-%{version}" that "n" looks strange. And
%{name}-%{version} is the default, so '%autosetup -p1' should suffice.
> find %{buildroot} -regex ".*\.la$" | xargs rm -f --
Just do find '%{buildroot} -name "*.la" -delete'
The -devel package requires you main package, so you don't need to put %license
in %files devel again.
--
I liked the reviews you did on other packages. I'll sponsor you once this
package is approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
