Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=633215 --- Comment #8 from Mat Booth <fed...@matbooth.co.uk> 2010-10-02 12:52:27 EDT --- Hi, More niggles, I'm afraid: 1. You need to add the licence to the main package still: %doc gpl.txt 2. Also, now you've moved the location of the jar files to a subdirectory, your simplyhtml.sh script no longer works, so you need to fix that. 3. Your package must also own that subdirectory, so in your files section, you should change this line: %{_javadir}/%{name}/*.jar To say this instead: %{_javadir}/%{name} 4. One thing I should perhaps have spotted earlier, by convention we normally "BuildRequires:java-devel" and "Requires:java" in Java packages. So although your other dependencies drag in all the necessary stuff, it's good practice to include those anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
