Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632912 Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org |mtas...@ioa.s.u-tokyo.ac.jp Flag| |fedora-review? --- Comment #5 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-10-03 15:22:36 EDT --- Sorry for late response. Well, * %check issue - rubygem(jeweler) is not strictly needed for $ rake test - also rubygem(shoulda) is only for gem.add_development_dependency and not needed for $ rake test - However Rakefile itself is broken for $ rake test. Please consider to apply the following patch and enable $ rake test on %check. ----------------------------------------------------------------- $ diff -u Rakefile.debug Rakefile --- Rakefile.debug 1970-01-01 09:00:00.000000000 +0900 +++ Rakefile 2010-09-13 02:32:52.000000000 +0900 @@ -21,7 +21,7 @@ require 'rake/testtask' Rake::TestTask.new(:test) do |test| test.libs << 'lib' << 'test' - test.pattern = 'test/**/*_test.rb' + test.pattern = 'test/**/test_*.rb' test.verbose = true end @@ -38,7 +38,7 @@ end end -task :test => :check_dependencies +#task :test => :check_dependencies task :default => :test ----------------------------------------------------------------- * Creating -doc subpackage - For rubygem based rpms, We usually suggest to create -doc subpackages, make -doc subpackage have "Requires: %{name} = %{version}-%{release}" and move the following files / directories to -doc subpackage. ---------------------------------------------------------------- %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/Rakefile %{geminstdir}/test ---------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
