https://bugzilla.redhat.com/show_bug.cgi?id=1428202

Damian Wrobel <dwro...@ertelnet.rybnik.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dwrobel@ertelnet. |
                   |rybnik.pl)                  |



--- Comment #16 from Damian Wrobel <dwro...@ertelnet.rybnik.pl> ---
Few comments:

# general license is GPLv2+ but BSD for 3rdParty/json.hpp
License:        GPLv2+ and BSD

Now when json 3rdparty had been unbundled the BSD part seems to not be
applicable any longer.


Based on the build-log and debug-info I see that lxqt-wallet seems to be used
(the bundled) version. It looks that we have in fedora[1]. Please consider to
unbundle.


As per [2] it would be nice to include appdata (for convenience Debian seems to
have it, see: [3]).


[1]. https://admin.fedoraproject.org/pkgdb/package/rpms/lxqt-wallet/
[2]. https://fedoraproject.org/wiki/Packaging:AppData 
[3]. https://packages.debian.org/sid/amd64/sirikali/filelist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to