https://bugzilla.redhat.com/show_bug.cgi?id=1487966
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebo...@gmail.com
Assignee|nob...@fedoraproject.org |zebo...@gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,
There are several issues:
- You install a *.so in libdir: you must run ldconfig in %post and %postun
See https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
%post
/sbin/ldconfig
%postun
/sbin/ldconfig
- You install a systemd user unit dir: these must be handled by systemd
scriplets too. See
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd
First you need to modify your systemd BR by adding a macro before it:
%{?systemd_requires}
BuildRequires: systemd
Then you add the scriplets in %post, %preun, %postun:
%post
%systemd_post libcloudproviders.service
%preun
%systemd_preun libcloudproviders.service
%postun
%systemd_postun_with_restart libcloudproviders.service
- The Release tag should starts at 1, not 0 (0.1 if it's a development
snapshot).
- Why do you split %files? Just reunite the two sections:
%files
%doc CHANGELOG README.md
%license LICENSE
%{_libdir}/libcloudproviders.so.*
%{_libexecdir}/cloudproviderd
%{_datadir}/cloud-providers/org.freedesktop.CloudProviderServerExample.ini
%{_datadir}/dbus-1/services/org.freedesktop.CloudProviderServerExample.service
%{_userunitdir}/libcloudproviders.service
- Your changelog is empty! It must contain the date, name, version and so on:
* Sun Sep 3 2017 Carlos Soriano <csori...@redhat.com> - 0.1.1-1
- Initial RPM release
Once all of this is fixed, I'll continue the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
