https://bugzilla.redhat.com/show_bug.cgi?id=1491714
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,
- Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- There's a typo in Source0: ${name} should be %{name}
- Also you can simplify your Source0: like this:
Source0:
https://github.com/LinuxCNC/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
- You should provide a -doc subpackage:
Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 5621760 bytes in 966 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- You should provide a systemd service file instead of a init.d script.
- There are too much rpmlint errors to list them here, I suggest you run
rpmlint on your end and fix the errors.
* For example there are plenty of incorrect-fsf-address files, you should
patch them with the correct address.
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
* Remove shebang from Python file:
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
* A setuid-binary /usr/bin/rtapi_app root 4755
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
