https://bugzilla.redhat.com/show_bug.cgi?id=1499408
--- Comment #5 from Igor Gnatenko <ignate...@redhat.com> --- > - Is there a reson for versioning the package as pre-release of 3.0 instead > of a post-release of 2.0? I could not find any tags upstream pointing that > the next release will be 3.0 and you may have problems if upstream releases > 2.1 our 2.0.1 for example. upstream CMakeLists.txt has 3.0-alpha and also soname has 3.0.0 version > - The LICENSE file should be shipped in the -devel sub-package as well No because it requires main package > - The include/hidapi/hidapi.h file seems to be licensed under GPLv3, taken > for another repository. Shouldn't and 'and' tag for GPLv3 be added in the > License tag? It is not installed and I will make sure to remove it in %prep during import > - Finally, rpmlint complains about unused shard lib dependency for libm. Was > this required by the compiler? Just making sure you are aware. I will report a bug to upstream. However, this is not blocker. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
