https://bugzilla.redhat.com/show_bug.cgi?id=1504512

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,

 - I don't think you should provide both python2 and python3 versions: this is
a binary, not a library. Remove the subpackages and keep the main to compile
with Python 3.

 - You mustn't include a license file if upstream hasn't provided one. What you
could do is extract the LICENSE from the README:

sed -e '0,/^## The MIT License/d' README.md > LICENSE

 - Split your description to stay below 80 characters per line

 - You must add the version in the %changelog:

* Fri Sep 15 2017 Nadie LKF Omar Berroteran Silva <omarberroteran...@gmail.com>
- 2.0-1

 - Use:

Source0:      
https://github.com/bhrigu123/classifier/archive/%{commit}/%{name}-%{version}.tar.gz
 

 - You should probably report the failing tests upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to