https://bugzilla.redhat.com/show_bug.cgi?id=1506722

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com
            Summary|Review Request:             |Review Request:
                   |python-octaviaclient-       |python-octaviaclient -
                   |Client for OpenStack        |Client for OpenStack
                   |Octavia (Load Balancer as a |Octavia (Load Balancer as a
                   |Service)                    |Service)



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,

 - Did you forget to put the Version and Release infos?

Version:        XXX
Release:        XXX

⇒

Version:        1.1.0
Release:        1%{?dist}

 - There is no %changelog entry either!

* Thu Oct 26 2017 Carlos Goncalves <cgoncal...@redhat.com> - 1.1.0-1
- Initial RPM release

 - No need to complicate things, use version instead of upstream_version and
remove upstream_version definition

%autosetup -n %{name}-%{version}

 - You could use the %{py2_dist/%{py3_dist macros to handle your BR and R. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

 - BuildRequires:  openstack-macros

There is no package openstack-macros in Fedora repositories. You'll have to
package it beforehand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to