https://bugzilla.redhat.com/show_bug.cgi?id=1508332
William Moreno <williamjmore...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #3 from William Moreno <williamjmore...@gmail.com> ---
Package Review
==============
Not bloquers here, package aproved
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Rpmlint
-------
Checking: php-icewind-smb2-2.0.3-1.fc28.noarch.rpm
php-icewind-smb2-2.0.3-1.fc28.src.rpm
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) libsmbclient ->
clientele
php-icewind-smb2.noarch: W: summary-not-capitalized C php wrapper for smbclient
and libsmbclient-php
php-icewind-smb2.noarch: W: spelling-error %description -l en_US smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US libsmbclient
-> clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US api -> API,
pi, ape
php-icewind-smb2.noarch: W: spelling-error %description -l en_US autoload ->
auto load, auto-load, tautology
php-icewind-smb2.src: W: spelling-error Summary(en_US) smbclient -> clientele
php-icewind-smb2.src: W: spelling-error Summary(en_US) libsmbclient ->
clientele
php-icewind-smb2.src: W: summary-not-capitalized C php wrapper for smbclient
and libsmbclient-php
php-icewind-smb2.src: W: spelling-error %description -l en_US smbclient ->
clientele
php-icewind-smb2.src: W: spelling-error %description -l en_US libsmbclient ->
clientele
php-icewind-smb2.src: W: spelling-error %description -l en_US api -> API, pi,
ape
php-icewind-smb2.src: W: spelling-error %description -l en_US usr -> use, us,
user
php-icewind-smb2.src: W: spelling-error %description -l en_US autoload -> auto
load, auto-load, tautology
2 packages and 0 specfiles checked; 0 errors, 15 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error Summary(en_US) libsmbclient ->
clientele
php-icewind-smb2.noarch: W: summary-not-capitalized C php wrapper for smbclient
and libsmbclient-php
php-icewind-smb2.noarch: W: spelling-error %description -l en_US smbclient ->
clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US libsmbclient
-> clientele
php-icewind-smb2.noarch: W: spelling-error %description -l en_US api -> API,
pi, ape
php-icewind-smb2.noarch: W: spelling-error %description -l en_US autoload ->
auto load, auto-load, tautology
php-icewind-smb2.noarch: W: invalid-url URL: https://github.com/icewind1991/SMB
<urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
Source checksums
----------------
https://github.com/icewind1991/SMB/archive/8394551bf29a37b884edb33dae8acde369177f32/php-icewind-smb2-2.0.3-8394551.tar.gz
:
CHECKSUM(SHA256) this package :
f00b3ab998fe19f2f5e1310bd06965ca575e9e1198d090fe19d9165036926398
CHECKSUM(SHA256) upstream package :
f00b3ab998fe19f2f5e1310bd06965ca575e9e1198d090fe19d9165036926398
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
