Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593800 Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org |mtas...@ioa.s.u-tokyo.ac.jp Flag| |fedora-review? --- Comment #34 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-10-15 13:55:20 EDT --- Well, for -3: * BR: - "BuildRequires: kdelibs-devel" is not needed. "BR: kdelib4-devel" is sufficient. * Comments in macro - Please use %% instead of % in comment line to avoid unexpected macro expansion. And again, BuildRoot tag (line) is no longer needed on Fedora and EPEL6. * %description ---------------------------------------------------------------------- python-keyring-kwallet.i686: E: description-line-too-long C Integrate python-keyring with KWallet so passwords can be read from/stored in the KWallet database. ---------------------------------------------------------------------- - Please cut this line into 2 or so so that one line in %description won't exceed 79 characters. * Filtering Provides/Requires ----------------------------------------------------------------------- %global _use_internal_dependency_generator 0 %global __find_provides %{_rpmconfigdir}/find-provides | grep -v 'gnome_keyring\|kde_kwallet' %global __find_requires %{_rpmconfigdir}/find-requires | grep -v 'gnome_keyring\|kde_kwallet' ----------------------------------------------------------------------- - Again this is not working. For example: ----------------------------------------------------------------------- # rpm -qp --provides python-keyring-gnome-0.2-3.fc14.i686.rpm gnome_keyring.so python-keyring-gnome = 0.2-3.fc14 python-keyring-gnome(x86-32) = 0.2-3.fc14 ----------------------------------------------------------------------- If you want to filter out "gnome_keyring.so" correctly, please refer to: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering e.g. https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Arch-specific_extensions_to_scripting_languages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
