https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #5 from Petr Pisar <ppi...@redhat.com> ---
> TODO: The description text is missing a full stop before "It" word.
Ok.
> FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod
> states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.
Ok.
> FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153).
Ok.
> FIX: Build-require 'perl(I18N::LangTags::Detect)'
> (lib/Mojolicious/Plugin/I18N.pm:6).
Ok.
> FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2).
Ok.
> FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4).
Ok.
> FIX: Build-require 'perl(Mojolicious::Plugin)'
> (lib/Mojolicious/Plugin/I18N.pm:2)'.
Ok.
> FIX: Build-require 'perl(base)' (t/i18n.t:16).
Ok.
> FIX: Build-require 'perl(lib)' (t/i18n.t:2).
Ok.
> FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16).
Ok.
> FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).
Ok.
> TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as
> you build-require it.
Ok.
Fix: Build-require 'perl(utf8)' (t/i18n.t:3).
All tests pass. Ok.
$ rpmlint perl-Mojolicious-Plugin-I18N.spec
../SRPMS/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm
../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm
perl-Mojolicious-Plugin-I18N.noarch: E: wrong-script-interpreter
/usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl
/usr/bin/env perl
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm
drwxr-xr-x 2 root root 0 Jan 8 10:29
/usr/share/doc/perl-Mojolicious-Plugin-I18N
-rw-r--r-- 1 root root 965 Aug 11 2015
/usr/share/doc/perl-Mojolicious-Plugin-I18N/Changes
drwxr-xr-x 2 root root 0 Aug 11 2015
/usr/share/doc/perl-Mojolicious-Plugin-I18N/script
-rw-r--r-- 1 root root 586 Aug 11 2015
/usr/share/doc/perl-Mojolicious-Plugin-I18N/script/App.pm
-rw-r--r-- 1 root root 446 Aug 11 2015
/usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl
-rw-r--r-- 1 root root 98 Aug 11 2015
/usr/share/doc/perl-Mojolicious-Plugin-I18N/script/test.mail.ep
-rw-r--r-- 1 root root 3254 Jan 8 10:29
/usr/share/man/man3/Mojolicious::Plugin::I18N.3pm.gz
drwxr-xr-x 2 root root 0 Jan 8 10:29
/usr/share/perl5/vendor_perl/Mojolicious
drwxr-xr-x 2 root root 0 Jan 8 10:29
/usr/share/perl5/vendor_perl/Mojolicious/Plugin
-rw-r--r-- 1 root root 8488 Jan 8 10:29
/usr/share/perl5/vendor_perl/Mojolicious/Plugin/I18N.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f |
uniq -c
1 perl(:MODULE_COMPAT_5.26.1)
1 perl(constant)
1 perl(I18N::LangTags)
1 perl(I18N::LangTags::Detect)
1 perl(Mojo::Base)
1 perl(Mojo::URL)
1 perl(Mojolicious) >= 5
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require 'perl(Mojolicious::Plugin)'
(lib/Mojolicious/Plugin/I18N.pm:2).
FIX: Run-require 'perl(strict)' (lib/Mojolicious/Plugin/I18N.pm:143).
FIX: Run-require 'perl(warnings)' (lib/Mojolicious/Plugin/I18N.pm:144).
FIX: Constrain 'perl(I18N::LangTags)' run-time dependency with '>= 0.35'
(META.json:36).
$ rpm -q --provides -p
../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f |
uniq -c
1 perl(Mojolicious::Plugin::I18N) = 1.6
1 perl(Mojolicious::Plugin::I18N::_Handler)
1 perl-Mojolicious-Plugin-I18N = 1.6-1.fc28
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm
Binary dependencies resolvable. Ok.
The package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=24071493). Ok.
Please correct all 'FIX' items and provide a new spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
