https://bugzilla.redhat.com/show_bug.cgi?id=1534567
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebo...@gmail.com
Assignee|nob...@fedoraproject.org |zebo...@gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- If you package a dev snapshot, you should provide the commit date in the
Release: field.
%global commit e863d83e403e8d694fa7d17f4af3cd176624ef12
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20171219
Name: golang-%{provider}-%{project}-%{repo}
Version: 0
Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
And:
* Mon Jan 15 2018 Marek Skalický <mskal...@redhat.com> -
0-0.1.20171219gite863d83
- You should remove:
%files
%license LICENSE
%doc README.md AUTHORS
as it only contains doc and license
- Tests fail on all arches:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24218445
+ go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
github.com/spacemonkeygo/openssl
# github.com/spacemonkeygo/openssl
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:80:
Fatal call has possible formatting directive %s
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/key_test.go:294:
Fatal call has possible formatting directive %s
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:38:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha1_test.go:76:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:38:
Fatal call has possible formatting directive %x
../../BUILDROOT/golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64/usr/share/gocode/src/github.com/spacemonkeygo/openssl/sha256_test.go:76:
Fatal call has possible formatting directive %x
FAIL github.com/spacemonkeygo/openssl [build failed]
To solve this, I propose you a simple patch which replaces the problematic
"Fatal" with "Fatalf":
diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go
--- openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go.fix_go_warning
2018-01-06 00:06:25.000000000 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/key_test.go 2018-01-15
20:00:40.727292766 +0100
@@ -77,7 +77,7 @@ func TestMarshal(t *testing.T) {
}
tls_der := x509.MarshalPKCS1PrivateKey(tls_key)
if !bytes.Equal(der, tls_der) {
- t.Fatal("invalid private key der bytes: %s\n v.s. %s\n",
+ t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n",
hex.Dump(der), hex.Dump(tls_der))
}
@@ -291,7 +291,7 @@ func TestMarshalEC(t *testing.T) {
t.Fatal(err)
}
if !bytes.Equal(der, tls_der) {
- t.Fatal("invalid private key der bytes: %s\n v.s. %s\n",
+ t.Fatalf("invalid private key der bytes: %s\n v.s. %s\n",
hex.Dump(der), hex.Dump(tls_der))
}
diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go
---
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go.fix_go_warning
2018-01-06 00:06:25.000000000 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha1_test.go 2018-01-15
20:01:38.878103115 +0100
@@ -35,7 +35,7 @@ func TestSHA1(t *testing.T) {
}
if expected != got {
- t.Fatal("exp:%x got:%x", expected, got)
+ t.Fatalf("exp:%x got:%x", expected, got)
}
}
}
@@ -73,7 +73,7 @@ func TestSHA1Writer(t *testing.T) {
}
if got != exp {
- t.Fatal("exp:%x got:%x", exp, got)
+ t.Fatalf("exp:%x got:%x", exp, got)
}
}
}
diff -up
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go
---
openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go.fix_go_warning
2018-01-06 00:06:25.000000000 +0100
+++ openssl-e863d83e403e8d694fa7d17f4af3cd176624ef12/sha256_test.go
2018-01-15 20:02:17.046978632 +0100
@@ -35,7 +35,7 @@ func TestSHA256(t *testing.T) {
}
if expected != got {
- t.Fatal("exp:%x got:%x", expected, got)
+ t.Fatalf("exp:%x got:%x", expected, got)
}
}
}
@@ -73,7 +73,7 @@ func TestSHA256Writer(t *testing.T) {
}
if got != exp {
- t.Fatal("exp:%x got:%x", exp, got)
+ t.Fatalf("exp:%x got:%x", exp, got)
}
}
}
- Sadly this isn't the end of it because now arch ppc64le fails:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24218725
+ go test -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
github.com/spacemonkeygo/openssl
/tmp/go-build647360343/b001/openssl.test: error while loading shared libraries:
R_PPC64_ADDR16_HA reloc at 0x000000013e65178c for symbol `' out of range
FAIL github.com/spacemonkeygo/openssl 0.002s
Digging around I found this commit
https://go-review.googlesource.com/c/go/+/73970 which suggests to use
-buildmode=pie for %gotest:
%gotest "-buildmode=pie" %{import_path}
And voilà, it passes a Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24219903
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 3 files have unknown license. Detailed output of licensecheck
in /home/bob/packaging/review/golang-github-spacemonkeygo-openssl
/review-golang-github-spacemonkeygo-openssl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/spacemonkeygo(golang-github-
spacemonkeygo-flagfile-devel, golang-github-spacemonkeygo-spacelog-
devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-spacemonkeygo-openssl-devel , golang-github-spacemonkeygo-
openssl-unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define gobuild(o:) go build
-ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d
' \\n')" -a -v -x %{?**};
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.x86_64.rpm
golang-github-spacemonkeygo-openssl-devel-0-0.1.gite863d83.fc28.noarch.rpm
golang-github-spacemonkeygo-openssl-unit-test-devel-0-0.1.gite863d83.fc28.x86_64.rpm
golang-github-spacemonkeygo-openssl-0-0.1.gite863d83.fc28.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
