https://bugzilla.redhat.com/show_bug.cgi?id=1534787
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebo...@gmail.com
Assignee|nob...@fedoraproject.org |zebo...@gmail.com
Flags| |fedora-review?
--- Comment #3 from Robert-André Mauchin <zebo...@gmail.com> ---
- %description
%{sum}
Description is not good enough, what is Fast Avro, what does it do?
- Fix your tests by building the Cython modules first:
%check
%__python2 setup.py build_ext --inplace
PYTHONPATH=. pytest-2 tests
%__python3 setup.py build_ext --inplace
PYTHONPATH=. pytest-3 tests
- Installation error:
DEBUG util.py:479: Last metadata expiration check: 0:00:00 ago on mar. 16
janv. 2018 14:33:57 CET.
DEBUG util.py:479: Error:
DEBUG util.py:479: Problem 1: conflicting requests
DEBUG util.py:479: - nothing provides python3dist(snappy) needed by
python3-fastavro-0.17.1-1.fc28.x86_64
DEBUG util.py:479: Problem 2: conflicting requests
DEBUG util.py:479: - nothing provides python2dist(snappy) needed by
python2-fastavro-0.17.1-1.fc28.x86_64
DEBUG util.py:617: Child return code was: 1
For some reason, %{py2_dist snappy} and %{py3_dist snappy} don't work, replace
them with %{py2_dist python-snappy} and %{py3_dist python-snappy} (It's the
"official" Pypi name).
- [!]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python2-fastavro (summary), python2-fastavro
(description), python3-fastavro (summary), python3-fastavro
(description)
%{sum} is not defined anywhere thus is not replaced in the description at build
time. Anyhow the summary is not enough for the description.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache (v2.0)". 80
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-fastavro/review-python-
fastavro/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python2-fastavro (summary), python2-fastavro
(description), python3-fastavro (summary), python3-fastavro
(description)
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-fastavro , python3-fastavro
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-fastavro-0.17.1-1.fc28.x86_64.rpm
python3-fastavro-0.17.1-1.fc28.x86_64.rpm
python-fastavro-debuginfo-0.17.1-1.fc28.x86_64.rpm
python-fastavro-debugsource-0.17.1-1.fc28.x86_64.rpm
python-fastavro-0.17.1-1.fc28.src.rpm
python2-fastavro.x86_64: W: unexpanded-macro Summary(C) %{sum}
python2-fastavro.x86_64: W: unexpanded-macro %description -l C %{sum}
python3-fastavro.x86_64: W: unexpanded-macro Summary(C) %{sum}
python3-fastavro.x86_64: W: unexpanded-macro %description -l C %{sum}
python3-fastavro.x86_64: W: no-manual-page-for-binary fastavro
python-fastavro-debugsource.x86_64: W: no-documentation
python-fastavro.src: W: unexpanded-macro %description -l C %{sum}
5 packages and 0 specfiles checked; 0 errors, 7 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
