https://bugzilla.redhat.com/show_bug.cgi?id=1507103
Jan Friesse <jfrie...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jfrie...@redhat.com
--- Comment #33 from Jan Friesse <jfrie...@redhat.com> ---
@digimer:
I've quickly checked the
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-4.fc26.src.rpm and
found following issues:
- warning: bogus date in %changelog: Tue Jan 31 2018 Madison Kelly
<mke...@alteeve.ca> - 1.0-4 <-- Should be Wed
- capitalize the summary (so for example convert "libknet1 crypto plugins meta
package" ->> "Libknet crypto....", libknet1 openssl support -> "Libknet openssl
support", ...)
- Please try to follow
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires . We need
explicit requires for plugins-all, but they should be properly versioned and
some small comment why we need it would be nice to have.
- Please remove old cruft:
%clean
rm -rf %{buildroot}
%defattr(-,root,root,-) in %files
- I know kronosnetd is not going to be distributed right now, but fixing
groupadd as
https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation may
be good idea.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
