https://bugzilla.redhat.com/show_bug.cgi?id=1546376
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebo...@gmail.com
Assignee|nob...@fedoraproject.org |zebo...@gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,
- This should be in the -devel subpackage:
%{_libdir}/libmetal.so
See https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
- There should probably be a %make_build before %make_install to use parallel
computation:
%build
%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} -DWITH_STATIC_LIB=OFF .
%make_build
- It's also usual to build in a subdir:
%build
mkdir build && cd build
%cmake -DCMAKE_INSTALL_LIBDIR=%{_libdir} -DWITH_STATIC_LIB=OFF ..
%make_build
%install
cd build
%make_install
- Your -devel subpackage should require the main package:
%package devel
Summary: Development files for libmetal
Requires: %{name}%{?_isa} = %{version}-%{release}
Consequently you don't need to add %license LICENSE.md in the -devel
subpackage.
- Not an error, just a preference: you could move %ldconfig_scriptlets
after %install, I almost miss it way down after %files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
