Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645244 Remi Collet <fed...@famillecollet.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fed...@famillecollet.com --- Comment #1 from Remi Collet <fed...@famillecollet.com> 2010-10-22 14:21:34 EDT --- Quick notes before actual review. > BuildRequires: php-pear >= 1.4.3 even if package (upstream) requires only pear 1.4.3, you must BR upper BuildRequires: php-pear >= 1:1.4.9-1.2 which is the first release which provides the needed macros (%{pecl_xmldir}...) (or you must redefine default value for all this macros) > Requires: php-common >= 5.1.0 this is not needed as you BR php-devel >= 5.1.0, and zend-abi will be check it (that you install with the same "major" version that you build with) > %post If you plan to push this package to EPEL-5, you still need to use the conditional scriplet > W: private-shared-object-provides Yes, we probably need to work on an improvment of PHP Guidelines ;) >From : http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Removing_items_from_the_provides_stream_.28post-scan_filtering.29 You should add : %{?filter_setup: %filter_from_provides /%{pecl_name}.so/d %filter_setup } (and yes, we need to fix all existing pecl packages in fedora) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
