https://bugzilla.redhat.com/show_bug.cgi?id=1550595

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin <zebo...@gmail.com> ---
Thanks Lukas, I'm not a SELinux specialist so I didn't take this package, I''ll
finish the review now.


 - These are not needed as this is the default:

%defattr(-,root,root,0755)
%attr(0644,root,root)
%attr(0644,root,root)


 - The latest version of tpm2-abrmd is 1.3.1, please bump your package.

 - The version in the header and the %changeloq are mismatched:

* Thu Mar 01 2018 Javier Martinez Canillas <javi...@redhat.com> - 0.0.1-1

  It should be 1.2.0-1 (or 1.3.1-1 when you update)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to