https://bugzilla.redhat.com/show_bug.cgi?id=1565504

Javier Peña <jp...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jp...@redhat.com
           Assignee|nob...@fedoraproject.org    |jp...@redhat.com



--- Comment #1 from Javier Peña <jp...@redhat.com> ---
Hi Chandan,

I have some initial comments on the spec:

* For the with_python3 statement, the latest Fedora reviews use the following
snippet:

%if 0%{?fedora} || 0%{?rhel} > 7
%global with_python3 1
%endif

* Python 3 build requirements are missing

* There is a test directory in the PyPi tarball. I'm not sure if we want to
keep it, if not we should %exclude it in the %files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to