https://bugzilla.redhat.com/show_bug.cgi?id=1565848

Iwicki Artur <fed...@svgames.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fed...@svgames.pl



--- Comment #1 from Iwicki Artur <fed...@svgames.pl> ---
>URL:    https://github.com/rizsotto/%{name}
>Source: https://github.com/rizsotto/%{name}/archive/%{version}.tar.gz
Don't repeat yourself; use %{URL} as part of Source.

>BuildRequires: cmake make python gcc
>Requires: python
With Python2 being slowly phased out, I believe you should use an explicit
"python2" or "python3" requires.

>$ head -n1 /usr/bin/bear
>#!/usr/bin/env python
"/usr/bin/env" MUST NOT be used. Edit this line with awk, or through a Patch,
and make it use "/usr/bin/python{2,3}".
https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines

>%doc %{_mandir}/man1/bear.1*
Man pages should not be marked as %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to