https://bugzilla.redhat.com/show_bug.cgi?id=1578151
Jitka Plesnikova <jples...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #1 from Jitka Plesnikova <jples...@redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
$ rpm -qp --requires perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
1 perl(Carp)
1 perl(constant)
1 perl(DBD::Pg)
1 perl(DBI)
1 perl(:MODULE_COMPAT_5.26.2)
1 perl(Mojo::Base)
1 perl(Mojo::Collection)
1 perl(Mojo::File)
1 perl(Mojo::IOLoop)
1 perl(Mojo::JSON)
1 perl(Mojo::Loader)
1 perl(Mojo::Pg::Database)
1 perl(Mojo::Pg::Migrations)
1 perl(Mojo::Pg::PubSub)
1 perl(Mojo::Pg::Results)
1 perl(Mojo::Pg::Transaction)
1 perl(Mojo::Promise)
1 perl(Mojo::URL)
1 perl(Mojo::Util)
1 perl(Scalar::Util)
1 perl(SQL::Abstract::Pg)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add run-requires
perl(SQL::Abstract) >= 1.85 (lib/SQL/Abstract/Pg.pm:2 and Makefile.PL:33)
TODO: Please consider adding following versioned run-requires (Makefile.PL:33)
perl(DBD::Pg) >= 3.005001
perl(Mojolicious) >= 7.53
$ rpm -qp --provides perl-Mojo-Pg-4.08-1.fc29.noarch.rpm | sort | uniq -c
1 perl(Mojo::Pg) = 4.08
1 perl-Mojo-Pg = 4.08-1.fc29
1 perl(Mojo::Pg::Database)
1 perl(Mojo::Pg::Migrations)
1 perl(Mojo::Pg::PubSub)
1 perl(Mojo::Pg::Results)
1 perl(Mojo::Pg::Transaction)
1 perl(SQL::Abstract::Pg)
Binary provides are Ok.
$ rpmlint ./perl-Mojo-Pg*
perl-Mojo-Pg.noarch: W: spelling-error Summary(en_US) Mojolicious -> Malicious
perl-Mojo-Pg.src: W: spelling-error Summary(en_US) Mojolicious -> Malicious
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok
Please correct all 'FIX' issues and consider fixing 'TODO' items.
Otherwise the package looks good.
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
