https://bugzilla.redhat.com/show_bug.cgi?id=1571742
Per Bothner <p...@bothner.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p...@bothner.com
--- Comment #2 from Per Bothner <p...@bothner.com> ---
Some preliminary informal comments, based on just the GitHub project.
These are my personal opinions/suggestions as a Fedora user, not a Fedora
packing expert.
* I think you need to make a case for why this should be in Fedora. It would
be helpful if you linked to some web-page that actually uses the library - i.e.
some real-life non-trivial web-page (with non-trivial styling). Perhaps
documentation or the home page for some other Fedora package (or proposed
package).
* How does your navigator deal with multiple pages? It seems it can only be
useful for navigating a single-page document. This limits its usefulness. For
comparison, I wrote a side-bar navigator for Kawa that handles navigation both
between and within pages. For example try:
https://www.gnu.org/software/kawa/Strings.html#Immutable-String-Constructors .
It might be useful to combine your logic for watching scrolling into my
side-bar navigator.
* Using the GPL license for a JavaScript library means (I believe) that all of
the JavaScript on a web page has to be released under the GPL. This may be a
concern for some people, and limit take-up - and possibly its suitability for
Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WQU3IXZJQFIHOQQ6OP6FA755FG4G4S7Z/
