Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=647076 --- Comment #4 from Golo Fuchert <packa...@golotop.de> 2010-10-28 18:50:41 EDT --- I had a closer look at your SPEC file and found some more issues: - Some BuildRequires depend on others, so not all BuildRequires need to be listed: gtk2-devel depends on automake libgnomecanvas-devela depends on gtk2-devel libsamplerate-devel depends on pulseaudio-libs-devel libxml2-devel depends on zlib-devel - I do not understand why you need 'export CPPFLAGS="$RPM_OPT_FLAGS"'. Maybe I am missing something but aren't the $RPM_OPT_FLAGS used anyway? - You have to take a closer look at the %files section, the package creates directories it does not own. They wouldn't be deleted when the package is removed for example. You may find this useful: http://fedoraproject.org/wiki/Packaging:UnownedDirectories Finally, I have a question concerning the icon file you provide additionally. Where does it come from? Are there any licence issues or is it safe to include it? I would recommend to make a comment on this in the SPEC file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
