https://bugzilla.redhat.com/show_bug.cgi?id=1586199
--- Comment #1 from Jun Aruga <jar...@redhat.com> ---
At first 2 things that I want to ask.
1.
> #-devel
> # BuildRequires: rubygem(posix-spawn)
Why does the only gem: posix-spawn for development is kept as commented line?
While the other gems guard are removed.
2.
> # Test failing with:
> # expected: "mogrify", got: nil
> sed -i '/^ it "assigns :mogrify by default" do$/,/ end/ s/^/#/g' \
> spec/lib/mini_magick/configuration_spec.rb
Seeing the source code, this failure happens when mogrify command (ImageMagick
package) is not installed. As you are setting ImageMagick as a build
dependency, you can remove this sed command line, right?
But after removing the line, you will face a different test failure of
ImageMagick unique tests.
```
Failures:
1) With ImageMagick MiniMagick::Image#details returns a hash of verbose
information
Failure/Error: expect(subject.details["Channel depth"]["Red"]).to eq
"8-bit"
expected: "8-bit"
got: nil
(compared using ==)
# ./spec/lib/mini_magick/image_spec.rb:423:in `block (5 levels) in <top
(required)>'
```
Seeing the source code, the MiniMagick::Image#details is an output of "identify
-verbose" command. But maybe the result is invalid. Maybe ImageMagik on Fedora
is something wrong. This happens on your environment? Can you dig this or
report to the project?
```
<mock-chroot> sh-4.4# rpm -qf /usr/bin/identify
ImageMagick-6.9.9.38-1.fc29.x86_64
<mock-chroot> sh-4.4# identify -verbose
=> The result is empty
<mock-chroot> sh-4.4# identify --help
identify: unable to open image `--help': No such file or directory @
error/blob.c/OpenBlob/2761.
identify: no decode delegate for this image format `' @
error/constitute.c/ReadImage/504.
```
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DDZZAOTFSRJ5CS2DB6CDFDBOTD7CYVNQ/
