https://bugzilla.redhat.com/show_bug.cgi?id=1591473



--- Comment #4 from Charles Rose <charles_r...@dell.com> ---
(In reply to Robert-André Mauchin from comment #3)
>  - Perms are incorrect:
> 
> sassist.noarch: E: non-standard-executable-perm /usr/bin/sassist.sh 555
> 
> It should be 755.

Fixed.

> 
>  - Your changelog entries are missing the release info:
> 
> * Thu Jun 14 2018 Charles Rose <charles_r...@dell.com> - 0.8.2-1

Fixed.

> 
>  - You should also execute the systemd scriptlets for
> sassist-collect.service:

The sassist-collect service is not started/stopped under user-control but is
triggered a volume is mounted:

media-iDRAC_NATOSC.mount:
...
BindsTo=sassist-collect.service
...

sassist-collect.service:
...
RefuseManualStart=true
...

> 
> %post
> %systemd_post sassist.service
> %systemd_post sassist-collect.service
> 
> %preun
> %systemd_preun sassist.service
> %systemd_preun sassist-collect.service
> 
> %postun
> %systemd_postun_with_restart sassist.service
> %systemd_postun_with_restart sassist-collect.service
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2EQHTI22MBHUNHSNXFWLCYCRS4M54ENQ/

Reply via email to