https://bugzilla.redhat.com/show_bug.cgi?id=1586117
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin <zebo...@gmail.com> ---
- Not needed:
rm -rf $RPM_BUILD_ROOT
- The Source0 should be a URL linking to the archive:
Source0:
https://github.com/Netronome/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
- This is deprecated in Fedora:
Requires: python-zmq
BuildRequires: python python-sphinx python-sphinx_rtd_theme
You must specify python2-devel and the python version for the packages:
%if 0%{?rhel} && 0%{?rhel} <= 7
Requires: python-zmq
%else
Requires: python2-zmq
%endif
BuildRequires: python2-devel python2-sphinx python2-sphinx_rtd_theme
- ExclusiveArch: x86_64 aarch64 ppc64le
Why no %{ix86} like dpdk?
- Use %make_build instead of make
- Don't:
%post
systemctl daemon-reload
Instead use the proper Systemd scriptlets:
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd
%{?systemd_requires}
BuildRequires: systemd
%post
%systemd_post virtio-forwarder.service
%systemd_post vio4wd_core_scheduler.service
%preun
%systemd_preun virtio-forwarder.service
%systemd_preun vio4wd_core_scheduler.service
%postun
%systemd_postun_with_restart virtio-forwarder.service
%systemd_postun_with_restart vio4wd_core_scheduler.service
- the %changelog entry is wrongly formatted, it should be:
* Tue Jun 12 2018 Frik Botha <frik.bo...@netronome.com> - 1.1.99.14-1
- Use the correct macros in %files:
%{_bindir}/virtio-forwarder
%{_mandir}/man8/virtio-forwarder.8.gz
%{_libdir}/virtio-forwarder
%config(noreplace) %{_sysconfdir}/default/virtioforwarder
%{_unitdir}/virtio-forwarder.service
%{_unitdir}/vio4wd_core_scheduler.service
- Use * instead of .gz for the manpage as the compression can change in the
future:
%{_mandir}/man8/virtio-forwarder.8.*
- You must install the LICENSE file and should install the README file:
%files
%doc README.md
%license LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IM274U4EZ5FKVW4U3GFDIUJP27CAWCAA/
