https://bugzilla.redhat.com/show_bug.cgi?id=1594601

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
 - Not needed:

rm -rf $RPM_BUILD_ROOT

 - If I'm not mistaken, it seems you're missing some Requires:/BR used in lib/
and bin/ :

base
Carp
charnames
Cwd
Data::Dumper
DB_File
Encode
File::Copy
File::Path
File::Spec
File::Temp
FindBin
HTTP::Response
HTTP::Request
IO::Socket
List::Util
Math::Trig
Pod::Find
POSIX
strict
Term::ANSIColor
Text::Balanced
Text::Wrap
Unicode::Normalize
warnings

 - Run the tests:

%check
make test

 - The LICENSE file should be installed with %license, not doc:

%license LICENSE

 - Perms for binaries should be 755:

LaTeXML.noarch: E: non-standard-executable-perm /usr/bin/latexml 555
LaTeXML.noarch: E: non-standard-executable-perm /usr/bin/latexmlc 555
LaTeXML.noarch: E: non-standard-executable-perm /usr/bin/latexmlfind 555
LaTeXML.noarch: E: non-standard-executable-perm /usr/bin/latexmlmath 555
LaTeXML.noarch: E: non-standard-executable-perm /usr/bin/latexmlpost 555

   Run:

%{_fixperms} $RPM_BUILD_ROOT/*

   after make pure_install

 - Add the Release-Version info in your %changelog entry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/66GNKP2UHHKNUTAN3FW73P5H5TF5PZLN/

Reply via email to