https://bugzilla.redhat.com/show_bug.cgi?id=1592254
--- Comment #2 from Anderson Sasaki <ansas...@redhat.com> ---
> Some issues that are worth considering:
> 1) This package conflicts with slurm-gui package. (/usr/bin/smap)
Ouch! I was not aware of this package. I will find a solution soon (probably
renaming the executable)
2) %{python3_sitelib}/* is not nice, you might end up owning
%{python3_sitelib}/__pycache__ for example. Since you do not install any
top-level cache, this is not the case, but you never know what future versions
will bring. You could do something like %{python3_sitelib}/smap/*, which is
more acceptable.
Agreed. I missed that on the Fedora Python Packaging Guidelines, more
specifically https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling.
It says explicitly that you should not do that. I'll fix it.
3) %check, perhaps you could package the test dependency first or skip the
failing part of tests? (this will probably will not be required to accept the
package, but it would be nice to have working tests)
Agreed. I am working with the upstream developer to package the test
dependency. So this will probably be blocked until I finish packaging it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FHVVVJ7A2GLI2FCJ4YJXZDRLM2MC7BDC/
