https://bugzilla.redhat.com/show_bug.cgi?id=1585758



--- Comment #5 from Petr Špaček <petr.spa...@nic.cz> ---
Here is refreshed version of packages:

https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-rawhide-x86_64/00778557-lua-cqueues/lua-cqueues-20171014-0.fc29.src.rpm

https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-rawhide-x86_64/00778557-lua-cqueues/lua-cqueues.spec


As far as I can tell it addresses all problems pointed above except two
nitpicks:
1. Bug in Lua packaging
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: 
     /usr/share/lua/5.3, /usr/lib64/lua/5.3
This was addressed by
https://src.fedoraproject.org/rpms/lua/pull-request/2
but it will take some time until new packages are built.


2. The unversioned .so is still unversioned because it is in private dir and
the only interface it has is Lua interface so it does not really matter (as
others pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1585758#c3).


3. Weird spelling suggestions. These texts come directly from project page so
it does not make sense to rewrite it.

It should be ready for formal review, I will look into docs and set flags
accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CN6G4VZFLJQO5NCSJT4W3WJS7TG7X7VC/

Reply via email to