https://bugzilla.redhat.com/show_bug.cgi?id=1619528
--- Comment #8 from Robert-André Mauchin <zebo...@gmail.com> ---
- As Lukáš noted, add a comment explaining why the patch is needed.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
- I don't get this:
# curl https://api.github.com/repos/jlebon/textern/tarball/5339fb6 > tarball
Source0: jlebon-textern-%gitrev.tar.gz
Grab the tar.gz directly:
Source0: %url/archive/%{gitrev}/%{name}-%{gitrev}.tar.gz
- Version/Release is not good. See the rules on versioning a snapshot:
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
%global commit 5339fb6ae33c72c27f2769d0fc3dabb6191b5d3a
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global snapshotdate 20180821
%global debug_package %nil
# this enforces us to create non-noarch package
%global native_dir %_libdir/mozilla/native-messaging-hosts
%global __brp_python_bytecompile :
Name: textern
Version: 0
Release: 0.3.%{snapshotdate}git%{shortcommit}%{?dist}
Summary: Firefox add-on for editing text in your favorite external
editor
License: GPLv3
URL: https://github.com/jlebon/textern
Source0: %url/archive/%{shortcommit}/%{name}-%{shortcommit}.tar.gz
And
%prep
%autosetup -p1 -n textern-%commit
Note the 0.3 instead of 3 for a pre-release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/X22HRM5MYNXSJNSVW7WR3LJC7KTGL7OY/
