https://bugzilla.redhat.com/show_bug.cgi?id=1622347



--- Comment #3 from Chris King <bunnyapocaly...@protonmail.com> ---
(In reply to Robert-André Mauchin from comment #2)
> Per this guidelines, it should be:
> 
> Provides: wpebackend = %{version}-%{release} 
> Obsoletes: wpebackend < 0.2.0-2

Ah, I had a feeling I messed up there, fixed.

>  - Source0 is 404. It should be:
> 
> Source0:       
> https://github.com/WebPlatformForEmbedded/libwpe/releases/download/
> %{version}/%{name}-%{version}.tar.xz

I have made this change

>  - Split the description to stay below 80 characters per line. Shorten the
> summary and remove the dot at the end

Fixed

>  - The %changelog Version-Release entry is not correct:

Fixed

Thanks again for another wonderful review Robert!

New spec:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/wpewebkit-rawhide/fedora-rawhide-x86_64/00791555-libwpe/builder-live.log
New SRPM:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/wpewebkit-rawhide/fedora-rawhide-x86_64/00791555-libwpe/libwpe-1.0.0-1.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to